Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(frontend)[Age 1343]: Implementation home view onboarding #2313

Merged
merged 43 commits into from
Dec 9, 2024
Merged

(frontend)[Age 1343]: Implementation home view onboarding #2313

merged 43 commits into from
Dec 9, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Nov 27, 2024

Closes AGE-1343

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:08am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:08am

@mmabrouk
Copy link
Member

@bekossy that looks good! Small comment, the image resolution in the demo example is low, why is that?

ardaerzin
ardaerzin requested changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left 1 comment, but it can be applied to other components that import modals

agenta-web/src/pages/apps/[app_id]/overview/index.tsx Outdated Show resolved Hide resolved
mmabrouk
mmabrouk approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my side, lgtm.
Only two minor comments are in slack. Please address them before merging

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 6, 2024
@bekossy bekossy requested a review from ardaerzin December 7, 2024 19:41
@bekossy bekossy marked this pull request as draft December 9, 2024 10:59
@bekossy bekossy marked this pull request as ready for review December 9, 2024 11:04
ardaerzin
ardaerzin approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the change @bekossy 🙏 lgtm

@jp-agenta jp-agenta merged commit b25cb78 into main Dec 9, 2024
9 checks passed
@jp-agenta jp-agenta deleted the AGE-1343/-implement-home-view-onboarding branch December 9, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp-agenta jp-agenta jp-agenta approved these changes

@ardaerzin ardaerzin ardaerzin approved these changes

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
cypress Frontend lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bekossy @mmabrouk @ardaerzin @jp-agenta